-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Aegis Reset Functionality to use titan chassis ref instead of raw index #788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indices make sense in pdata, tbh it would be better for this ClientCommand to take a titanRef (from the titanClasses enum in pdef) instead of a raw index.
Thanks for the suggestion, changed the method to this and its not swapping between the 3 loadouts due to UI loadout index mismatching with the pdata index. Current method now is even better so that players can call the command from console and literally have to type the titan chassis name they want to reset (e.g: want to reset Monarch just use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicks
Northstar.CustomServers/mod/scripts/vscripts/sh_progression.nut
Outdated
Show resolved
Hide resolved
Northstar.CustomServers/mod/scripts/vscripts/sh_progression.nut
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
159ce14
to
30b91f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gets Titan chassis id based on name which addresses the passed index not matching up with the one in pdef.
While function signature is updated in this PR, there's no code in Northstar yet that calls it, so no additional changes needed.
Skipping testing for this one cause it's cumbersome and the change appears to be obvious.
Currently the index method reset does not correspond properly with the persistent data index, a method of picking titan by their class reference is the optimal idea so this ensures the correct titan will get their Aegis Levels to reset.
Related: