Fix map rotation for Hide-and-Seek and remove duplicate entries #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2024
GeckoEidechse
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
From the code review side of things, this basically just reorders the map list to match the order of other gamemodes and removes duplicate entries.
I didn't test this but the two changed modes are CTF and Hide and Seek both of which should work on all common maps.
|
Actually, I think I'll split up the last remaining change as well ^^ |
GeckoEidechse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only editsplaylists_v2.txtand fixes two issues.Several gamemode map rotations would have stacks listed twice right after one another, which caused a server to remain on stacks permanently.--> #793Additionally, some gamemodes had maps listed several times 1, while this wouldn't put a server stuck on a map permanently, it would create loops which caused some maps to never appear despite being listed.
Footnotes
The change for CTF was moved to Fix map rotation for CTF and remove duplicate entries #795 ↩