Update tbshotgun mdls with skinfamillies/lods, add pbr materials #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r +skin31 support
- Both ptpov and w_ models now have proper skinfamillies resembling average r2 weapon setup (default/skin31/prime 0-6)
- Replaced missing audio events with already existing sounds:
// open
// { event AE_CL_PLAYSOUND 4 "SG_Twin_B.Reload_Open" }
//
// { event AE_CL_PLAYSOUND 3 "wpn_softball_reload_start_mech_fr05_1p" }
//
// eject
// { event AE_CL_PLAYSOUND 8 "SG_Twin_B.Reload_Eject" }
//
// { event AE_CL_PLAYSOUND 0 "Weapon_Sidewinder_Reload_1_1P" }
//
// load shell
// { event AE_CL_PLAYSOUND 20 "SG_Twin_B.Reload_InsertMag" }
//
// { event AE_CL_PLAYSOUND 8 "Weapon_Mastiff_Reload_LoadShell" }
//
// close
// { event AE_CL_PLAYSOUND 19 "SG_Twin_B.Reload_Close" }
//
// { event AE_CL_PLAYSOUND 28 "Weapon_RE45_Reload_MagInsert" }
//
// draw
// { event AE_CL_PLAYSOUND 0 "SG_twinB.Draw" }
//
// { event AE_CL_PLAYSOUND 0 "Weapon_R101_Equip" }
//
// holster
// { event AE_CL_PLAYSOUND 0 "SG_twinB.Holster" }
//
// { event AE_CL_PLAYSOUND 0 "Weapon_R101_UnEquip" }
//
- removed references textures and models referencing weapons which were used as base for tb.
- rpak is now only 1024x for tb, shell is 512x.
- rpak now contains newly created skin31 material + dummy materials for prime skins 1-6 to prevent missing texture issues
GeckoEidechse
added
needs testing
- UVs in certain spots were wonky, and made lod changes very distracting - lod positions were changed from [10,30,50] to [25,30,50] to minimize pop-in from 0-1, especially visible in thirdperson. all lod changes were done with maxed model quality.
|
Since I used lod positions from wingman, db started looking wonky when swapping lods. Mostly in third person. I tested the lod25 pos in PMs and it works perfectly, the lod still swaps in tpp @110fov w/o zoom, but as soon as you ads with any weapon it swaps to lod0. tldr: corrected uvs and made sure lod swaps are seamless. |
|
Looks fine ingame, didnt realize there were actual sound events for the db ingame, even fitting the reload perfectly. Guess respawn had the model done and just gave it to nexon then :/ But yeah pr is fine lovin the pbr :) |
GeckoEidechse
added
READY TO MERGE
EM4Volts
approved these changes
Jun 29, 2024
GeckoEidechse
removed
the
needs code review
GeckoEidechse
changed the title
GeckoEidechse
approved these changes
Jul 6, 2024
There was a problem hiding this comment.
Signing off based on previous review done by @EM4Volts who added the twin-barrel shotgun initially
|
Putting this in the next feature release, consider this essentially merged :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ptpovandw_models now have proper skinfamillies resembling average r2 weapon setup (default/skin31/prime 0-6)lod0-lod3models to thew_model1024xfor tb, shell is512x.