-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix weapon drop callback breaking SP #797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason the callbacks aren't defined for both SP and MP?
I can't be 100% sure as it's not my code, but looking at the original pr it's used in MP to destroy weapon drops if they aren't allowed, instead of the solution which apparently didn't always work before More than willing to edit this to work for SP also, but I was just concerned on making the game not crash |
bump |
I haven't made any changes due to not having a reply on editing the code to instead work on SP I suppose the main question would be do we want to move the functions to be above the |
Moving those functions inside the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can confirm that this works completely fine on singleplayer, played through most of a mission, executed a grunt, no issues at all |
The functions for both weapon drop callbacks are in an
#if MP
statement, but the globalization wasn't, causing SP to try to add the functions, which it didn't find as MP wasn't active. Without this change, you compile error before SP finishes loadingSidenote: genuinely wtf is that last line diff. I didn't touch it??
sideline 2: ok i did actually touch it now but it still shows the exact same thing even after removing the newline, idk man
Related: