Only fetch MAD manifesto on server join

[Alystrasz]

Previously, the verified mods manifesto was fetched on game start without checking if the verified mod feature is enabled Squirrel-side; with this, the manifesto is only fetched when the user wants to download a mod (meaning they enabled the feature beforehand).

(must be merged with the launcher PR!)

Mod changes

• Squirrel VM now has the responsability to fetch verified mods manifesto;
• When joining a server requiring mods, if said mods aren't found in current player profile, verified mods manifesto will be fetched to check if they can be automatically downloaded.

TODOs

• Launcher counterpart PR (Only fetch MAD manifesto on server join NorthstarLauncher#751)
• Fetch manifesto when joining a server
• Make Northstar able to handle several versions of the same mod (will do later)

Testing

Without PRs:

1. Launch game;
2. Check the logs: they should display verified mods manifesto was fetched close to game launch;

With PRs:

1. Install both launcher and mods PRs;
2. Launch game, reach MP lobby and enable MAD (allow_mod_auto_download 1);
3. Try and connect to a server requiring verified mods (Space battle or Parkour server should be up at the time of writing);
4. Check the logs: manifesto should be fetched when trying to join the server.

Media

delayed_manifesto_fetching.webm

(if you look closely, you can see verified mods manifesto is fetched WHEN joining the server, around 0:12 in the video)

[GeckoEidechse]

So uh I may have found an issue with requiring the exact matching mod version :3

[Alystrasz]

So uh I may have found an issue with requiring the exact matching mod version :3

Well, main branch indeed is not up-to-date: https://github.com/R2Northstar/NorthstarMods/blob/main/Northstar.Custom/mod.json#L4
I guess final mods version is set in the CI when creating a release?

[GeckoEidechse]

So uh maybe we should re-consider requiring exact matching version (or add an exception for Northstar.Custom (or Northstar.* in general)

In particular, cause the Northstar.Custom version I had was none matching, I got

And this is with MAD disabled btw

[GeckoEidechse]

I guess final mods version is set in the CI when creating a release?

Yes but regardless of that we have the issue where if someone is not running the exact same version as server (maybe cause server is slightly outdated which is often the case) we end up with client being unable to join despite there not necessarily being breaking changes. Not sure what the best approach is here tbh...

[Alystrasz]

I guess final mods version is set in the CI when creating a release?

Yes but regardless of that we have the issue where if someone is not running the exact same version as server (maybe cause server is slightly outdated which is often the case) we end up with client being unable to join despite there not necessarily being breaking changes. Not sure what the best approach is here tbh...

I guess we can be tolerant regarding core mods and simply add an exception to the rule regarding Northstar.* mods?

[GeckoEidechse]

I guess we can be tolerant regarding core mods and simply add an exception to the rule regarding Northstar.* mods?

Yeah, I'd say that's the way to go until we figure out a nicer system ^^

[Alystrasz]

So uh maybe we should re-consider requiring exact matching version (or add an exception for Northstar.Custom (or Northstar.* in general)

In particular, cause the Northstar.Custom version I had was none matching, I got

And this is with MAD disabled btw

This should be fixed with 9f1eb45.

[GeckoEidechse]

Confirmed working in testing together with R2Northstar/NorthstarLauncher#751

Enabled MAD and joined a server. Observed the delayed manifesto fetching as intended.

[GeckoEidechse]

@Zanieon offered to do code review some time soon later ^^
After that it's ready to merge together with R2Northstar/NorthstarLauncher#751

[Zanieon]

Code looks alright to me, good to go.