Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant parameter in DownloadMod #827

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Remove redundant parameter in DownloadMod #827

merged 3 commits into from
Jul 31, 2024

Conversation

wolf109909
Copy link
Contributor

@wolf109909 wolf109909 commented Jul 30, 2024 •
edited
Loading

yes

@GeckoEidechse GeckoEidechse requested a review from Alystrasz July 30, 2024 21:44
Alystrasz
Alystrasz approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter is a leftover of a previous refactor, and isn't used anywhere in the function.

Zanieon
Zanieon approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@Zanieon Zanieon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uneeded parameter yeah.

@GeckoEidechse GeckoEidechse merged commit ad2e09b into R2Northstar:main Jul 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alystrasz Alystrasz Alystrasz approved these changes

@Zanieon Zanieon Zanieon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wolf109909 @Zanieon @Alystrasz @GeckoEidechse