Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transferring active Stim ability to Titan and endless stim effects #864

Merged
merged 14 commits into from
Nov 27, 2024

Conversation

Gazyi
Copy link
Contributor

@Gazyi Gazyi commented Sep 4, 2024

In current version, if pilot has active Stim ability when embarking Titan, it'll be "transfered" to Titan. That's mostly noticeable when Stim has increased duration.
Tested with applied "bc_super_stim" mod. Notice Titan max velocity change after activating Stim:

NkH2YVR2.mp4

PR also applies fix for endless stim not having visual effects and sound not looping. However, there's still a problem with sound - sometimes even TF|1 looping sound stops working. I can't find a cause of this, but I suspect there's a limit of active sounds on entity, because it stops playing after pilot received a lot of damage.

@GeckoEidechse
Copy link
Member

This adds a new modified vanilla file, right? ^^

@GeckoEidechse GeckoEidechse added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 4, 2024
@Gazyi
Copy link
Contributor Author

Gazyi commented Sep 4, 2024

This adds a new modified vanilla file, right? ^^

Yes.

@GeckoEidechse
Copy link
Member

Which VPK/path? Cause then I fixup the PR to add that file first and then layer change on top of it. That way it's easier to see what got changed and gets the PR merged faster :D

@Gazyi
Copy link
Contributor Author

Gazyi commented Sep 4, 2024

Which VPK/path? Cause then I fixup the PR to add that file first and then layer change on top of it. That way it's easier to see what got changed and gets the PR merged faster :D

englishclient_mp_common.bsp.pak000_dir.vpk/scripts/vscripts/weapons/sh_stim.gnut

@GeckoEidechse GeckoEidechse self-assigned this Sep 4, 2024
@Zanieon Zanieon added the commits vanilla file For PRs that commit vanilla files from VPKs label Sep 4, 2024
@GeckoEidechse GeckoEidechse changed the title Fix transferring active Stim ability to Titan and endless stim effects. Fix transferring active Stim ability to Titan and endless stim effects Sep 5, 2024
@Alystrasz
Copy link
Contributor

@Gazyi could you provide instructions on how to test this PR?
(especially on the bc_super_stim mod part)

@NachosChipeados
Copy link
Contributor

NachosChipeados commented Nov 6, 2024

@Alystrasz 1. Call in your titan
2. Type give mp_ability_heal bc_super_stim in the console
3. Get in your titan

bc_super_stim is just a weapon mod for the stim, used for a TF1 burncard that just extends its lenght

Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any difference with and without this PR:

Without PR

titan_stim_withoutpr.webm

With PR

titan_stim_withpr.webm

Could you also give additional instructions to test the endless stim effect fix?

@Gazyi
Copy link
Contributor Author

Gazyi commented Nov 8, 2024

I don't see any difference with and without this PR:

Looks like previous version only stops endless stim effects, should be fixed with new commit.
Check velocity with cl_showpos 1.

Could you also give additional instructions to test the endless stim effect fix?

As Pilot, type script EndlessStimBegin( GetPlayerArray()[0], STIM_EFFECT_SEVERITY ) or script StimPlayer( GetPlayerArray()[0], USE_TIME_INFINITE ) in console.

@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Nov 14, 2024
@GeckoEidechse
Copy link
Member

Finally added the corresponding vanilla file and updated the PR accordingly o7

@GeckoEidechse GeckoEidechse removed commits vanilla file For PRs that commit vanilla files from VPKs merge conflicts Blocked by merge conflicts, waiting on the author to resolve labels Nov 14, 2024
@GeckoEidechse GeckoEidechse removed their assignment Nov 15, 2024
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, stim effect is not transfered to titan anymore, and stim loop sound correctly plays.
(tested today in private match)

@Alystrasz Alystrasz added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 24, 2024
@GeckoEidechse GeckoEidechse merged commit c3c2535 into R2Northstar:main Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants