-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when player is in a special team #866
Conversation
Northstar.CustomServers/mod/scripts/vscripts/mp/_gamestate_mp.nut
Outdated
Show resolved
Hide resolved
Co-authored-by: William Miller <[email protected]>
idk if im doing right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, and this will probably solve problems in regards to any gamemode isn't 2 sided based, or even if they partially uses Militia or IMC teams, it will work only between those teams.
Uh, what's the command to switch player teams again so that I can test this? ^^" |
There's no default way of doing it right now, you can only do either by using FSU and typing |
You could also do smth like |
u can try use this function
just like this comment
here is some team name u may need to know |
Tested this by using #872 and playing Free For All, so far server didn't complain, and probably it wouldn't as there's sanity checks in that team changing code. Besides... Only FFA Scoreboard supports more than 2 teams, all other gamemodes will crash clients that tries to open Scoreboard if trying to assign players to other than I also have to mention that i prefer this to get merged first over #875 so i can update the function there manually as Github probably will get confused and do a merge conflict for either PRs that gets merged last. |
Merging based on reviews, thanks @Zanieon |
my English is bad, im sorry for that :(