Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose more game state information to DiscordRPC #869

Merged
merged 4 commits into from
Sep 7, 2024
Merged

Expose more game state information to DiscordRPC #869

merged 4 commits into from
Sep 7, 2024

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Sep 7, 2024

Dependency of R2Northstar/NorthstarDiscordRPC#25 so it can work properly.

@Zanieon Zanieon added the depends on another PR Blocked until the PR it depends on is merged label Sep 7, 2024
@GeckoEidechse GeckoEidechse added needs code review Changes from PR still need to be reviewed in code and removed depends on another PR Blocked until the PR it depends on is merged labels Sep 7, 2024
@GeckoEidechse
Copy link
Member

Testing done by @catornot in R2Northstar/NorthstarDiscordRPC#25 (review)

@GeckoEidechse GeckoEidechse added the almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge label Sep 7, 2024
GeckoEidechse
GeckoEidechse approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extends gamestate struct with 3 more states and adds additional logic to modify that state based on current game state with some extra handling logic for Frontier Defense.

@GeckoEidechse GeckoEidechse removed needs code review Changes from PR still need to be reviewed in code almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Sep 7, 2024
@GeckoEidechse GeckoEidechse changed the title [Discord RPC] Presence update for server gamestates Expose more game state information to DiscordRPC Sep 7, 2024
@GeckoEidechse GeckoEidechse merged commit 62b9215 into R2Northstar:main Sep 7, 2024
3 checks passed
@Zanieon Zanieon deleted the discordRPCgamestate branch September 7, 2024 21:02
@GeckoEidechse GeckoEidechse mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zanieon @GeckoEidechse