Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove clutter client logging in melee scripts #895

Merged
merged 10 commits into from
Nov 14, 2024
Merged

Remove clutter client logging in melee scripts #895

merged 10 commits into from
Nov 14, 2024

Conversation

NachosChipeados
Copy link
Contributor

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 14, 2024
@GeckoEidechse GeckoEidechse added the commits vanilla file For PRs that commit vanilla files from VPKs label Oct 14, 2024
ASpoonPlaysGames
ASpoonPlaysGames approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just removes a bunch of debug printing that honestly nobody outside of respawn is using

@ASpoonPlaysGames ASpoonPlaysGames removed the needs code review Changes from PR still need to be reviewed in code label Oct 21, 2024
@GeckoEidechse GeckoEidechse self-assigned this Oct 22, 2024
Alystrasz
Alystrasz approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I can confirm logs are no longer polluted with melee-related information in game.

JMM889901
JMM889901 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@JMM889901 JMM889901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, prints are annoying

@Alystrasz Alystrasz added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs testing Changes from the PR still need to be tested labels Nov 7, 2024
@GeckoEidechse GeckoEidechse removed the commits vanilla file For PRs that commit vanilla files from VPKs label Nov 14, 2024
@GeckoEidechse GeckoEidechse merged commit 227e7ef into R2Northstar:main Nov 14, 2024
3 checks passed
@NachosChipeados NachosChipeados deleted the melee_prints branch November 15, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse left review comments

@Zanieon Zanieon Zanieon left review comments

@ASpoonPlaysGames ASpoonPlaysGames ASpoonPlaysGames approved these changes

@JMM889901 JMM889901 JMM889901 approved these changes

@Alystrasz Alystrasz Alystrasz approved these changes

Assignees

@GeckoEidechse GeckoEidechse

Labels
almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NachosChipeados @Zanieon @Alystrasz @GeckoEidechse @JMM889901 @ASpoonPlaysGames