Fix client crash during final killcam #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
GeckoEidechse
added
the
commits vanilla file
github-actions
bot
added
the
merge conflicts
GeckoEidechse
removed
merge conflicts
|
Added the corresponding vanilla file to main and updated this PR so it only reflects the actual change. |
Bobbyperson
changed the title
ASpoonPlaysGames
approved these changes
Nov 18, 2024
ASpoonPlaysGames
added
READY TO MERGE
Zanieon
approved these changes
Nov 18, 2024
GeckoEidechse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All this PR does is add cl_screenfade.gnut from basegame to Northstar. It includes a fix at lines 250 and 252.This PR fixes a bug affecting Infection and possibly other gamemodes that causes a client crash during final killcam. The bug in question along with a detailed writeup can be found here Bobbyperson/InfectionRework#7 (this issue does affect base infection).Code review:
The added code is essentially copied from Vanilla code a few lines above.
Testing:
Testing the fix in question is quite difficult, as the bug is fairly random and hard to produce. However, because this same exact check is done just a few lines earlier and seems to be unintentionally missing, it shouldn't require any testing.