-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Spectre first person executions script error #910
base: main
Are you sure you want to change the base?
Fix Spectre first person executions script error #910
Conversation
Would it not be simpler to make our execution code fall back on |
Already thought about that, but i couldn't think of a good way to do it |
Potentially replace |
but thats the problem, we can't just tell it to hide any bodygroups because if the npc doesn't have them, we just run into the same issue again Titanfall.2.2024-12-01.22-32-19.mp4Here, i got an error because grunts don't have
I think there's definitely a better way to handle this entire thing, but i have no idea how else to do it |
Copied from discord: https://discord.com/channels/920776187884732556/950322078945538058/1313222452683210825
Could probably fairly easily prevent this code from crashing at all by checking the return value before trying to set the bodygroup, combined with the stuff I suggested should make a fairly robust way of doing this |
Fixes R2Northstar/Northstar#418 and the Spectre part of #885.
The reason this happens is because the fp executions code tries to find the
"head"
bodygroup, but Spectres have"removableHead"
instead, so i fixed it by:"removableHead"
bodygroup to"head"
"removableHead"
when referencing Spectres. The new code checks for"head"
first, and then falls back to"removableHead"
if it doesn't find it, so it shouldn't cause any issues if someone disablesNorthstar.Custom
or uses a Spectre model that doesn't have this changeTitanfall.2.2024-11-30.10-21-29.mp4
-
cl_spectre.nut
was taken fromenglishclient_mp_common.vpk
-
_ai_spectre.gnut
was taken fromenglishclient_sp_timeshift_spoke02.vpk
( but it should be in any sp vpk )I'd also like to note that Stalkers technically should have this issue as well, but we can't execute them so it doesn't really matter