Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite using Astro and enhance accordingly #75

Merged
merged 13 commits into from
Jul 26, 2024

Conversation

barnabwhy
Copy link
Contributor

@barnabwhy barnabwhy commented Jul 9, 2024

All changes are clearly objective improvements :3

Main page (with collapsed installers for demonstration)
Credits

Installers page: GONE!!!!!

Roadmap
Servers (unchanged aside from header)

closes #69
closes #71
supersedes #74

@GeckoEidechse
Copy link
Member

mf even added TypeScript on the side as well, I love it <3

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played around with it locally and I like the change a lot :D
Especially the the semi-translucient background on the extra pages and switching all the JS to TypeScript ^^

src/pages/roadmap.astro Outdated Show resolved Hide resolved
src/pages/index.astro Outdated Show resolved Hide resolved
@GeckoEidechse
Copy link
Member

@pg9182 for merging I suppose we just add an Action to build to github-pages branch or something and then pull from there on masterserver?

@barnabwhy
Copy link
Contributor Author

barnabwhy commented Jul 9, 2024

i guess closes #69 and #71

src/pages/404.astro Outdated Show resolved Hide resolved
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge from my side. Now we just gotta figure out deployment together with @pg9182 ^^

@GeckoEidechse GeckoEidechse added the enhancement New feature or request label Jul 10, 2024
@GeckoEidechse
Copy link
Member

We should probably also add basic instructions on how to build locally for anyone not familiar with astro but that shouldn't block this PR ^^

@barnabwhy
Copy link
Contributor Author

We should probably also add basic instructions on how to build locally for anyone not familiar with astro but that shouldn't block this PR ^^

should just be

$ yarn
$ yarn build

and then built files will be in ./dist

@GeckoEidechse
Copy link
Member

should just be

$ yarn
$ yarn build

and then built files will be in ./dist

Exactly. It's not difficult or anything, it's just that someone who never used NodeJS or the like might not be familiar with this. So just putting the commands somewhere is more than enough.

(Also, yarn dev not yarn build for live preview :P)

@GeckoEidechse
Copy link
Member

Waiting on a response from @pg9182 so that we can merge ^^

@GeckoEidechse GeckoEidechse changed the title Rewrite using Astro + Make stuff make more sense Rewrite using Astro and enhance accordingly Jul 26, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pg9182 gave me his blessing to test in prod. It worked using my fork that also adds an Action to deploy and so I'm gonna merge the PR accordingly and the PR the Action to deploy separately

Rendered from https://northstar.tf
image

@GeckoEidechse GeckoEidechse merged commit 73933ca into R2Northstar:main Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style roadmap page more nicely Rebuild website using modern webframework
2 participants