-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite using Astro and enhance accordingly #75
Conversation
mf even added TypeScript on the side as well, I love it <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Played around with it locally and I like the change a lot :D
Especially the the semi-translucient background on the extra pages and switching all the JS to TypeScript ^^
@pg9182 for merging I suppose we just add an Action to build to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge from my side. Now we just gotta figure out deployment together with @pg9182 ^^
We should probably also add basic instructions on how to build locally for anyone not familiar with astro but that shouldn't block this PR ^^ |
should just be $ yarn
$ yarn build and then built files will be in ./dist |
Exactly. It's not difficult or anything, it's just that someone who never used NodeJS or the like might not be familiar with this. So just putting the commands somewhere is more than enough. (Also, |
Waiting on a response from @pg9182 so that we can merge ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pg9182 gave me his blessing to test in prod. It worked using my fork that also adds an Action to deploy and so I'm gonna merge the PR accordingly and the PR the Action to deploy separately
Rendered from https://northstar.tf
All changes are clearly objective improvements :3
Main page
(with collapsed installers for demonstration)Credits
Installers page: GONE!!!!!
Roadmap
Servers (unchanged aside from header)
closes #69
closes #71
supersedes #74