-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dedicated Hosting on windows file #223
base: main
Are you sure you want to change the base?
Conversation
…tarWiki into hosting-on-windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a dedicated hosting on Windows section definetely makes sense. That being said, I think this PR does a bit too much at once.
In particular, I don't think we should change the Best practices page to Windows hosting and then also adjust the content in the same PR.
Rather we should make a new page for Windows hosting that moves the appropriate content over and in a second PR then remove best practices if need be. ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see where gecko is coming from, but ultimately, this is still better than the current docs; if it was a massive PR that did unrelated (especially if it was code that could cause errors) things, I'd understand wanting it to be multiple PRs, but this is 32 lines of documentation.
please just separate out the two changes so that I can merge it <3 |
# ConVars | ||
## Monitoring | ||
|
||
You can set the Convar `ns_should_log_all_clientcommands` to `1` to log all client commands. This includes both benign things like the command a client sends to server to respawn after death but also nefarious, like a malicious client calling `emit`, a command that before being patched out allowed clients to spam voice lines to other clients. | ||
|
||
Due to the increased verbosity `ns_should_log_all_clientcommands` is set to `0` (disabled) by default but should be enabled in cases where you want to investigate suspicious activity on your server. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is from the best-practies page, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes copy paste
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, saw it as well now. Made #232 to move it out separately ^^
{% hint style="info" %} | ||
TODO: If you have experience in hosting Northstar servers and want to share your knowledge, please open a [pull request](https://github.com/R2Northstar/NorthstarWiki/pulls). | ||
{% endhint %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't feel fitting for Windows hosting page tbh ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tooooo much copy paste
docs/hosting-a-server-with-northstar/dedicated-server/hosting-on-windows.md
Outdated
Show resolved
Hide resolved
Co-authored-by: GeckoEidechse <[email protected]>
…on-windows.md Co-authored-by: GeckoEidechse <[email protected]>
4e3e475
to
b36f81b
Compare
I added a file that explains how to host on windows similarly to how "hosting on linux" is a thing