Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dedicated Hosting on windows file #223

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

NoCatt
Copy link
Contributor

@NoCatt NoCatt commented Sep 19, 2023

I added a file that explains how to host on windows similarly to how "hosting on linux" is a thing

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a dedicated hosting on Windows section definetely makes sense. That being said, I think this PR does a bit too much at once.

In particular, I don't think we should change the Best practices page to Windows hosting and then also adjust the content in the same PR.
Rather we should make a new page for Windows hosting that moves the appropriate content over and in a second PR then remove best practices if need be. ^^

Copy link
Contributor

@JMM889901 JMM889901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see where gecko is coming from, but ultimately, this is still better than the current docs; if it was a massive PR that did unrelated (especially if it was code that could cause errors) things, I'd understand wanting it to be multiple PRs, but this is 32 lines of documentation.

@GeckoEidechse
Copy link
Member

please just separate out the two changes so that I can merge it <3

docs/SUMMARY.md Outdated Show resolved Hide resolved
Comment on lines 1 to 7
# ConVars
## Monitoring

You can set the Convar `ns_should_log_all_clientcommands` to `1` to log all client commands. This includes both benign things like the command a client sends to server to respawn after death but also nefarious, like a malicious client calling `emit`, a command that before being patched out allowed clients to spam voice lines to other clients.

Due to the increased verbosity `ns_should_log_all_clientcommands` is set to `0` (disabled) by default but should be enabled in cases where you want to investigate suspicious activity on your server.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from the best-practies page, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes copy paste

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, saw it as well now. Made #232 to move it out separately ^^

Comment on lines +5 to +7
{% hint style="info" %}
TODO: If you have experience in hosting Northstar servers and want to share your knowledge, please open a [pull request](https://github.com/R2Northstar/NorthstarWiki/pulls).
{% endhint %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't feel fitting for Windows hosting page tbh ^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tooooo much copy paste

Co-authored-by: GeckoEidechse <[email protected]>
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflicts Blocked by merge conflicts, waiting on the author to resolve
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants