Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic debugging documentation #243

Merged
merged 8 commits into from
Oct 19, 2023
Merged

Add basic debugging documentation #243

merged 8 commits into from
Oct 19, 2023

Conversation

Jan200101
Copy link
Contributor

@Jan200101 Jan200101 commented Oct 15, 2023

Adds basic debugging documentation for Visual Studio and x64dbg

TODO:

  • Add Images to make it easier to follow
  • improve wording in Visual Studio docs
  • investigate if ScyllaHide is really needed on Windows (I needed it, others may not)
  • improve wording in x64dbg linux section

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like the additional info and the structure it's in.

Might make more sense to add a bit more info to debugging with Visual Studio but that can be done in separate PR and by someone else.

Regarding the open TODOs, I'm fine with merging the current version once the current comments are resolved and then make new PRs for the rest to get stuff published faster ^^

docs/development/debugging/README.md Outdated Show resolved Hide resolved
docs/development/debugging/x64dbg.md Outdated Show resolved Hide resolved
docs/development/debugging/x64dbg.md Outdated Show resolved Hide resolved
@GeckoEidechse
Copy link
Member

bump

@Jan200101
Copy link
Contributor Author

@GeckoEidechse done
4V tested if SycllaHide is needed for x64dbg and it is.
I've also added a warning to the debugging page that debugging Northstar is only recommended to experienced developers and that they should visit the Discord if they need help.

@EM4Volts
Copy link

can confirm. did test, had no idea what the fuck is going on but i did test.

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So from looking at it, it looks fine for me. Shout-out to @EM4Volts for testing as well <3

@GeckoEidechse GeckoEidechse merged commit 343b42c into R2Northstar:main Oct 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants