Update local_build.sh #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the `mkdir` and `chmod` lines to include using the "${RADIUSDESK_VOLUME}" variable, since its used in the rest of the script, and because we're sourcing .env.
Also, there's beyond no need in having `|| exit 1` on every line that does something, especially if we have to run this more than once. Like, if we already have an nginx server running and port 80 is already in use.
Also changed the network name out for the sourced variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
mkdirandchmodlines to include using the "${RADIUSDESK_VOLUME}" variable, since its used in the rest of the script, and because we're sourcing .env.Also, there's beyond no need in having
|| exit 1on every line that does something, especially if we have to run this more than once. Like, if we already have an nginx server running and port 80 is already in use.