-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows builds in CI #250
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #250 +/- ##
=====================================
Coverage 3.0% 3.0%
=====================================
Files 14 14
Lines 1753 1753
=====================================
Hits 53 53
Misses 1700 1700
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm looking for a solution for the |
I've opened BP-WG/bp-esplora-client#8 and add a commit here to fix the wasm build (I'll change the git dependency after the PR gets merged or I'll remove it if you release a new version of bp-esplora-client). Unfortunately there's no way to conditionally exclude dependencies based on target, so I had to add a dedicated feature for wasm. Moreover |
There is: [target.'cfg(target_arch = "wasm32")'.dependencies]
# your dependencies |
Sorry, I meant features, not dependencies. I've found this related open issue rust-lang/cargo#1197 so it seems it's not possible at the moment |
@dr-orlovsky all CI jobs pass, IMO this can be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8ceff54
This will fix the windows build on the CI by adding nasm as a dependency