-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete transfers with PSBT construction and tapret commitments #39
Conversation
7fd48dd
to
beeab18
Compare
Ok, I have finished implementing all functionality required to do a full transfer, from coin selection (including co-operative bitcoin and RGB coin selection), PSBT creation, DBC commitments (with possible combination of oprets/taprets, which are automatically deduced from the inputs) to the consignment creation - all in just a single method call (and in single cli command let (psbt, meta, transfer) = rgb.pay(invoice, method, params) I have no idea whether it works (pretty sure there are some bugs) - I will be debugging during the next few days. But at least, with the code written and compiling now I am sure we have everything we need in all our libraries (there are around 20 of them involved here) to have real RGB taproot wallets - a journey which took 3 years of my time and required implementing even taproot itself, twice (once in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool... Just one comment
#[display("transfer")] | ||
Transfer { | ||
/// Encode PSBT as V2 | ||
#[clap(short = '2')] | ||
v2: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a default value for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a flag, thus "default value" is false
assigned when the flag is absent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Complete transfers with PSBT construction and tapret commitments
No description provided.