Skip to content

Commit

Permalink
dsldevkit#22: SCA configuration - missed cleanups
Browse files Browse the repository at this point in the history
 - Catch some final cleanups of PMD

Issue: dsldevkit#22
  • Loading branch information
[email protected] authored and [email protected] committed Dec 20, 2017
1 parent 392c65b commit 06c69f8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
* A factory for creating CustomCheckProject objects.
*/
// CHECKSTYLE:OFF
@SuppressWarnings("nls")
public class CheckProjectFactory extends PluginProjectFactory {
// CHECKSTYLE:ON

Expand All @@ -45,7 +46,7 @@ protected void enhanceProject(final IProject project, final SubMonitor subMonito
* @throws CoreException
* the core exception
*/
@SuppressWarnings("nls")
@SuppressWarnings("PMD.InsufficientStringBufferDeclaration")
private void createPluginXML(final IProject project, final IProgressMonitor monitor) throws CoreException {
final StringBuilder content = new StringBuilder("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<?eclipse version=\"3.4\"?>\n");
content.append("<plugin>\n</plugin>\n");
Expand All @@ -59,6 +60,7 @@ private void createPluginXML(final IProject project, final IProgressMonitor moni
}

@Override
@SuppressWarnings("PMD.InsufficientStringBufferDeclaration")
protected void createBuildProperties(final IProject project, final IProgressMonitor progressMonitor) {
final StringBuilder content = new StringBuilder("source.. = ");
for (final Iterator<String> iterator = folders.iterator(); iterator.hasNext();) {
Expand All @@ -81,7 +83,7 @@ protected void createBuildProperties(final IProject project, final IProgressMoni
/**
* Overridden in order to change BundleVendor. {@inheritDoc}
*/
@SuppressWarnings("nls")
@SuppressWarnings("PMD.InsufficientStringBufferDeclaration")
@Override
protected void createManifest(final IProject project, final IProgressMonitor progressMonitor) throws CoreException {
final StringBuilder content = new StringBuilder("Manifest-Version: 1.0\n");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ private static URI getDefaultFormatLocation(final Grammar grammar, final XpandEx
* @throws FileNotFoundException
* thrown if the format file could not be found
*/
@SuppressWarnings("PMD.NPathComplexity")
public static FormatConfiguration getFormatModel(final Grammar grammar, final XpandExecutionContext context) throws FileNotFoundException {
Variable resourceUriVariable = context.getVariable("resourceUri");
if (resourceUriVariable == null) {
Expand Down

0 comments on commit 06c69f8

Please sign in to comment.