Make PFDA vignette not stop on error #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running on CentOS 7 with R 4.1.2 with fully-updated packages on 2022 March 17 produced the following error ``` --- re-building ‘faustPFDA.Rmd’ using rmarkdown Quitting from lines 426-439 (faustPFDA.Rmd) Error: processing vignette 'faustPFDA.Rmd' failed with diagnostics: Downdated VtV is not positive definite --- failed re-building ‘faustPFDA.Rmd’ ``` when building vignettes on install, which blocked the install. To allow the Rmd to complete even with the error (and allow at least to see part of that vignette and the other two vignettes when installing with vignettes), I added `error = TRUE` as an argument to `knitr::opts_chunk$set`.
In R3.6.3, using vectors with length greater than one in the condition of an if statement merely warned and used the first element, but past verion 4.something it throws an error. It's not entirely clear to me whether any or all would be better. Presumably any, as if there are any NAs then we would want to fix the behaviour. So that's what we went with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running on CentOS 7 with R 4.1.2 with fully-updated packages on 2022 March 17 produced the following error
when building vignettes on install, which blocked the install. To allow the Rmd to complete even with the error (and allow at least to see part of that vignette and the other two vignettes when installing with vignettes), I added
error = TRUEas an argument toknitr::opts_chunk$set.Of course, it would be better to fix the error, but this at least allows installation with two out of three vignettes.
Attached is a PDF of the output from running the PFDA vignette.
FAUST PFDA.pdf