fix: maven component analysis xml wrong parsing of x.0 versions ( x >=0) #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zvi Grinberg <[email protected]>
zvigrinberg
changed the title
Signed-off-by: Zvi Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In maven Component analysis , we're using xml-fast-parser in order to retrieve direct dependencies from pom.xml.
in case there is a string version in the format of "x.0" ( x is an integer, x >=0 ) , then by default it omits the ".0" and convert it to number as integer - x.
We need to configure xml fast parser to ignore such cases, so it will let the string become as is in case of format x.0 ( for every natural positive integer x >= 0).
Checklist