fix: missing common maven transitive dependencies #45
Conversation
|
Do not merge, it seems the current solution does not load the full sub-tree, only the omitted dependency. |
Signed-off-by: Ruben Romero Montes <[email protected]>
There was a problem hiding this comment.
@ruromero I Saw that there was a failure on test - RangeError: Maximum call stack size exceeded - couple of times actually - please check it out at : https://github.com/RHEcosystemAppEng/exhort-javascript-api/actions/runs/6051817204/job/16424074479?pr=45#step:7:107.
It seems that it's either the halting condition of the recursion is not met on such case, or it's using too much space complexity in this recursion on big trees
I'll try to figure out why it's happening for part of the tests ( while working on other tests).
Can you please take a look?
Thanks.
Signed-off-by: Zvi Grinberg <[email protected]>
Signed-off-by: Zvi Grinberg <[email protected]>
…rbose flag Signed-off-by: Zvi Grinberg <[email protected]>
…ke {+,\,-,(,|}
Signed-off-by: Zvi Grinberg <[email protected]>
There was a problem hiding this comment.
@ruromero Good Job.
As you could see, i pushed few fixes to your fork, so it will work correctly and all tests will succeeded.
I Approved it - please Merge whenever you are ready ( maybe you want to complete documentation or add something - linting warning for example - see comment below about that - anyway it's not critical at the moment)
Thanks.
zvigrinberg
changed the title
|
Thanks @zvigrinberg let me validate the use case reported by QE before merging |
ruromero
force-pushed
the
dep-tree
branch
3 times, most recently
from
0c80893 to
dbdc6b7
Compare
Signed-off-by: Ruben Romero Montes <[email protected]>
fix: missing common maven transitive dependencies
---------
Signed-off-by: Zvi Grinberg <[email protected]>
Signed-off-by: Ruben Romero Montes <[email protected]>
Co-authored-by: Ruben Romero Montes <[email protected]>
fix: missing common maven transitive dependencies --------- Signed-off-by: Zvi Grinberg <[email protected]> Signed-off-by: Ruben Romero Montes <[email protected]> Co-authored-by: Ruben Romero Montes <[email protected]>
fix: missing common maven transitive dependencies --------- Signed-off-by: Zvi Grinberg <[email protected]> Signed-off-by: Ruben Romero Montes <[email protected]> Co-authored-by: Ruben Romero Montes <[email protected]>
…ext tree format fixes: https://issues.redhat.com/browse/TC-562 Related to: RHEcosystemAppEng/exhort-javascript-api#45 Signed-off-by: Zvi Grinberg <[email protected]>
…ext tree format fixes: https://issues.redhat.com/browse/TC-562 Related to: RHEcosystemAppEng/exhort-javascript-api#45 Signed-off-by: Zvi Grinberg <[email protected]>
Description
The
dependency:treeplugin omits duplicates but when using theverboseflag the omitted are shown. However the plugin only yields thetexttype in that case.I have added the
verboseflag to themvn dependency:treecommand and changed how the text file is processed with thetextformat.Related issue (if any):
fixes #44
Checklist
Additional information
Related to RHEcosystemAppEng/exhort#135