fix: ignore optional non resolved dependencies #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvigrinberg
previously approved these changes
Sep 20, 2023
There was a problem hiding this comment.
@ruromero Thanks for the catch!
Just Please change the ts accordingly so tests will not fail.
...viders/tst_manifests/npm/package_json_deps_with_exhortignore_object/stack_expected_sbom.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Ruben Romero Montes <[email protected]>
2 tasks
zvigrinberg
pushed a commit
to RHEcosystemAppEng/exhort-java-api
that referenced
this pull request
Sep 26, 2023
## Description Skip optional non resolved npm dependencies I have also updated the npm test files to align with the javascript api so they allow more complex use cases **Related issue (if any):** Related to RHEcosystemAppEng/exhort-javascript-api#55 ## Checklist - [x] I have followed this repository's contributing guidelines. - [x] I will adhere to the project's code of conduct. ## Additional information Signed-off-by: Ruben Romero Montes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignore optional dependencies.
Related issue (if any): fixes #54
Checklist
Additional information