fix: couple of related problems with exhortignore in go.mod #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…regex that should capture all cases of packages names + versions in go.mod fix: in case of automatic version bump, the exhortignored package wrongly shown as a direct dependency in generated sbom fix: filter the exhortignored packages after sbom creation instead of during creation test: add new test that all direct dependencies are ignored, and update existing tests expected sbom Signed-off-by: Zvi Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: exhortignored not respected for couple of edge cases regex that should capture all cases of packages names + versions in go.mod
fix: in case of automatic version bump, the exhortignored package wrongly shown as a direct dependency in generated sbom
fix: filter the exhortignored packages after sbom creation instead of during creation
test: add new test that all direct dependencies are ignored, and update existing tests expected sbom
Related issue
fixes https://issues.redhat.com/browse/TC-573
Checklist
Additional information