Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(IQE-2748): Update sel testing image backend #787

Closed
wants to merge 2 commits into from

Conversation

akhil-jha
Copy link
Member

No description provided.

Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off topic question: so the pipeline tests frontend as well, it's just defined twice?
Can't we use the same pipeline definition whether it's triggered by backend or frontend merge? 🤔

Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is fine ofc :)

@akhil-jha
Copy link
Member Author

Off topic question: so the pipeline tests frontend as well, it's just defined twice? Can't we use the same pipeline definition whether it's triggered by backend or frontend merge? 🤔

This yaml is used to hms-integration testing.
We can use the same file for backend and frontend, for that we'd have to change the deploy.yml in app-interface, and make it point to a common file. But then in case we have to change the testing for backend and frontend, things will get tough.

@akhil-jha
Copy link
Member Author

I will merge this PR when frontend(merged) PR testing and deploy is done

@ezr-ondrej
Copy link
Member

But then in case we have to change the testing for backend and frontend, things will get tough.

I can't imagine a scenario when it would be useful, but we shouldn't base decisions on my lack of imagination, so if you feel it's useful, lets keep it that way! :)

@akhil-jha akhil-jha closed this Mar 26, 2024
@ezr-ondrej ezr-ondrej deleted the update_sel_testing_image branch March 26, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants