Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant call to retrieve issue comments #288

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Remove redundant call to retrieve issue comments #288

merged 1 commit into from
Apr 11, 2024

Conversation

dcritch
Copy link
Contributor

@dcritch dcritch commented Apr 11, 2024

We were making a separate call for comments, however the latest JIRA API docs show that we already have them when we pull a card. Removing the redundant separate call to retrieve them.

@dcritch dcritch requested a review from adhil0 April 11, 2024 17:05
adhil0
adhil0 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@adhil0 adhil0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, should cut down on API calls by several magnitudes

I've also verified that the output of issue.fields.comment.comments is identical to our previous implementation

@adhil0 adhil0 merged commit 6ce3a08 into main Apr 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhil0 adhil0 adhil0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcritch @adhil0