Add SONAME versioning #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Robert, Sorry it's taken a while for me to look at this. I had first merged your CI PRs to help spot problems. As this PR was created before the actions existed, the CI checks were not run. So I merged your PR into my own fork that has been recently rebased, and the CI checks fail on some build issues with your change (https://github.com/spakka/bgpdump/actions?query=branch%3Asoname-versioning) Can you rebase your branch against the latest master to bring in the CI checks, and then have a look at the build failures for this PR please? Also, for now please set SO Version to 1.6.2, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple attempt to address #11. If you would like to go into this direction in general, it could be improved, e.g. moving the soversion definitions to
configure.inand/or making the shared linking for the binaries optional using a./configureoption.This modernizes my previous pull request from https://bitbucket.org/ripencc/bgpdump/pull-requests/28/introduce-soname-versioning proposed at 2019-04-28.