Add Docker configuration for turtlebot3 environment #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wonho Yun <[email protected]>
yun-goon
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
@Woojin-Crive I confirmed that the topics are received properly even in Docker! Thank you for your contribution!
robotpilot
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
LGTM
@Woojin-Crive FYI, We have a docker account, I'll let you know later.
https://hub.docker.com/orgs/robotis/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request merges the
support-dockerbranch into the main branch, introducing Docker support to the turtlebot3 project. The changes in this branch aim to simplify the setup process and streamline the development environment through containerization.Summary of Changes
A new Dockerfile is provided to build a containerized environment for turtlebot3. This ensures that users can quickly and consistently set up the required build environment.
Motivation
Many users and contributors have expressed interest in a containerized setup that can simplify dependency management and environment configuration. By integrating Docker support, we reduce setup time and increase the reproducibility of builds and tests. This change helps new contributors get started quickly and makes the project more accessible.
Testing & Validation
The Docker container was built and run locally, and all essential functionalities were verified within the containerized environment.
Request for Review
Please review the changes and provide any feedback or suggestions. Your input is welcome to ensure that this new workflow integrates smoothly with our ongoing development process.