Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI pipeline #936

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add CI pipeline #936

wants to merge 1 commit into from

Conversation

tiopex
Copy link
Contributor

@tiopex tiopex commented Dec 9, 2024

CI pipeline for ROCKNIX

To merge this PR it is required:

Demo of working CI here (Every day at 3 am EST, a new build is created): https://github.com/tiopex/distribution/actions

Comment on lines +10 to +11
DEVICE_SPECIFIC_EMULATORS="${DEVICE_SPECIFIC_EMULATORS-true}"
COMMON_EMULATORS="${COMMON_EMULATORS-true}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DEVICE_SPECIFIC_EMULATORS="${DEVICE_SPECIFIC_EMULATORS-true}"
COMMON_EMULATORS="${COMMON_EMULATORS-true}"
# Split building emulators into 2 stages, needed to fit the jobs into the 6 hour nightly CI time limit.
DEVICE_SPECIFIC_EMULATORS="${DEVICE_SPECIFIC_EMULATORS-true}"
COMMON_EMULATORS="${COMMON_EMULATORS-true}"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to leave a comment here, so other devs understand why this has been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants