fix: fix N64 standalone start script

[LaurensBosscher]

Running the line with the "*" on the terminal gives the following output:

RK3566-X55:~ # cp /usr/local/share/mupen64plus/mupen64plus.cfg* /storage/.config/mupen64plus/mupen64plus.cfg
cp: can't create '/storage/.config/mupen64plus/mupen64plus.cfg/mupen64plus.cfg': Path does not exist
cp: can't create '/storage/.config/mupen64plus/mupen64plus.cfg/mupen64plus.cfg.rgarc': Path does not exist

I think this was added to support a device (instead of platform) specific configuration at some point but if we want to support this we need need further modification(s) for the install script/launch script. The current implementation breaks for all platforms and all systems.

[r3claimer]

This is a better way to handle for sure but this is not it and you will break several devices.

[LaurensBosscher]

This is a better way to handle for sure but this is not it and you will break several devices.

Hi @r3claimer, currently the configuration is broken for all platforms with multiple configurations in rocknix\distribution\packages\emulators\standalone\mupen64plus-sa\mupen64plus-sa-core\config:

With this fix we'll go from having all RK3266 and RK32566 devices being broken to "only" the device specific configurations not being applied. Currently no configuration file is being applied at all so to me this seems like a step in the right direction.

I understand that this is not the final solution but judging by the scripts we would need to access the device id (e.g the oga, ogab, ogs part in the filename) in the bash script somehow. I only see references to a PLATFORM, not a device id. Could you make a recommendation on how would we could do this?

Edit:

I see that for e.g ODroid Go Advanced we're taking care of the .oga part for the config in device quirks:

Handling device specific configurations in the device quirks seems sensible to me. Let me know if you agree.

If I'm reading the script correctly this will work with this fix. Since:

if [ -f "/storage/.config/mupen64plus/mupen64plus.cfg.ogabe" ]; then
  rm /storage/.config/mupen64plus/mupen64plus.cfg
  cp /storage/.config/mupen64plus/mupen64plus.cfg.ogabe /storage/.config/mupen64plus/mupen64plus.cfg
fi

Will copy the file to /storage/.config/mupen64plus/mupen64plus.cfg where start_mupen64plus.sh expects it to be.

Thus, in conclusion, this fix should work both for devices that have a device specific configuration file and for devices that don't. If a device specific configuration is not properly handled in the device quirks, I would recommend that we fix it in there instead of adding device specific code in the generic start_mupen64plus.sh script.

Could you double check this?

[spycat88]

Suggested change

	cp ${SHARE}/mupen64plus.cfg ${M64PCONF}
	cp ${SHARE}/mupen64plus.cfg* ${GAMEDATA}

I think this is the fix that @r3claimer is looking for.