This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
Use Google captive portal server for network connectivity checking #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonejack
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of
pingfor network connectivity checks with the method used on Android and iOS.Using
pingsends ICMP packets, which works well under a VPN but can cause issues with (transparent) proxies that only support TCP/HTTP traffic. For users who rely on proxy servers to improve download speeds for themes or OTA updates, a failed ping test could block them from downloading updates, even if they can still access GitHub over HTTP.