Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIPIFY][doc] Add codeowners for documentation #1301

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

samjwu
Copy link
Member

@samjwu samjwu commented Jan 24, 2024

Relates to ROCm/ROCm#2832
Adding documentation team as codeowners for documentation.
Goal is to make this group of code owners reviewers when merging documentation changes.

Please note that this requires the team to be added as a role with Write permissions.

@samjwu samjwu self-assigned this Jan 24, 2024
@emankov emankov changed the title Add codeowners for documentation [HIPIFY][doc] Add codeowners for documentation Jan 25, 2024
@emankov emankov self-requested a review January 25, 2024 14:59
@emankov emankov added the documentation Improvements or additions to documentation label Jan 25, 2024
@emankov
Copy link
Collaborator

emankov commented Jan 25, 2024

Done: the team @ROCm/rocm-documentation was added as a collaborator with Write permissions.

Copy link
Collaborator

@emankov emankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emankov emankov merged commit daeb83f into amd-staging Jan 25, 2024
2 checks passed
@samjwu samjwu deleted the documentation-codeowners branch January 25, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants