-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MI300 details to docs #446
Draft
peterjunpark
wants to merge
22
commits into
ROCm:develop
Choose a base branch
from
peterjunpark:docs/mi300
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+170
−121
Draft
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b3943e2
Change MI2XX to MI200. Add MI300 note
peterjunpark b43df09
Fix request flow image sizes
peterjunpark 29c451a
update UTCL1 hit-on-miss note to specify MI200
peterjunpark bcf1464
update sL1D size and how many CUs it's shared between
peterjunpark 26615c0
WIP: update L2 channel count for MI300
peterjunpark 28f7ad2
update wording
peterjunpark 809ebb9
WIP: supported features table
peterjunpark 6a44753
update l2 cache line size note for mi300
peterjunpark 6db105c
update agprs section
peterjunpark 42fc830
update l2 cache section
peterjunpark ccf2c62
add 128 read request to L2-Fabric transaction table
peterjunpark acc1ba1
update intro
peterjunpark 73e1994
update atomic requests for mi300
peterjunpark 3129cab
fix links
peterjunpark b440e35
fix link
peterjunpark d72c261
fix formatting issue
peterjunpark d5b3368
wording
peterjunpark 2bf9580
update "one per XCD" to l2 cache description
peterjunpark b1670c8
clarify l2 transaction sizes text
peterjunpark 201d0d0
wording
peterjunpark c7bc7bd
update l2 cache text
peterjunpark 98c356e
add back image width
peterjunpark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Table seems weird with just one entry right now, but I'm sure we had ideas on how to fill it :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, right, we probably want to (eventually) take a second pass and go through to find places where we distinguish values based on the architecture, like the waveslots discussion below (or AGPRs), and add them here.
That can probably wait till this is ~ finalized though