fix: split massive HIS code relationship queries into smaller ones

RRZE-Webteam · Jul 2, 2024 · 9710738 · 9710738
1 parent c171c04
commit 9710738
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 1 deletion.
diff --git a/src/Infrastructure/Repository/WordPressDatabaseDegreeProgramCollectionRepository.php b/src/Infrastructure/Repository/WordPressDatabaseDegreeProgramCollectionRepository.php
@@ -17,13 +17,15 @@ final class WordPressDatabaseDegreeProgramCollectionRepository implements Degree
 {
     public function __construct(
         private DegreeProgramViewRepository $degreeProgramViewRepository,
-        private WpQueryArgsBuilder $queryArgsBuilder
+        private WpQueryArgsBuilder $queryArgsBuilder,
+        private WpQuerySplitter $querySplitter
     ) {
     }
 
     public function findRawCollection(CollectionCriteria $criteria): PaginationAwareCollection
     {
         $query = new WP_Query();
+        $criteria = $this->querySplitter->maybeSplitQuery($criteria);
         /** @var array<int> $ids */
         $ids = $query->query(
             $this->queryArgsBuilder
@@ -48,6 +50,10 @@ public function findRawCollection(CollectionCriteria $criteria): PaginationAware
     public function findTranslatedCollection(CollectionCriteria $criteria, string $languageCode): PaginationAwareCollection
     {
         $query = new WP_Query();
+        $criteria = $this->querySplitter->maybeSplitQuery(
+            $criteria->withLanguage($languageCode)
+        );
+
         /** @var array<int> $ids */
         $ids = $query->query(
             $this->queryArgsBuilder

diff --git a/src/Infrastructure/Repository/WpQuerySplitter.php b/src/Infrastructure/Repository/WpQuerySplitter.php
@@ -0,0 +1,49 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Fau\DegreeProgram\Common\Infrastructure\Repository;
+
+use Fau\DegreeProgram\Common\Application\Repository\CollectionCriteria;
+use WP_Query;
+
+final class WpQuerySplitter
+{
+    public function __construct(
+        private WpQueryArgsBuilder $queryArgsBuilder
+    ) {
+    }
+
+    /**
+     * @param CollectionCriteria $criteria
+     * @return CollectionCriteria
+     */
+    public function maybeSplitQuery(CollectionCriteria $criteria): CollectionCriteria
+    {
+        $hisCodes = $criteria->hisCodes();
+
+        if (count($hisCodes) <= 1) {
+            return $criteria;
+        }
+
+        $ids = [];
+
+        foreach ($hisCodes as $hisCode) {
+            $criteria = $criteria->withHisCodes([$hisCode]);
+            $query = new WP_Query();
+            /** @var array<int> $ids */
+            $ids = array_merge(
+                $query->query(
+                    $this->queryArgsBuilder
+                        ->build($criteria)
+                        ->args()
+                ),
+                $ids
+            );
+        }
+
+        return $criteria
+            ->withHisCodes([])
+            ->withInclude($ids);
+    }
+}