Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default campo keys value #10

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented May 30, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
We are currently having issues with cached degree program data. The post meta values fau_cache_degree_program_raw and fau_cache_degree_program_translated don't include campo_keys value.

What is the new behavior (if this is a feature change)?
Added default values for campo_keys if the degree program data does not include them.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

@zhyian zhyian marked this pull request as ready for review May 30, 2024 07:57
@zhyian zhyian requested review from shvlv, tyrann0us and o-samaras May 30, 2024 07:57
Copy link
Collaborator

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@o-samaras o-samaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@zhyian zhyian merged commit 2541cfa into dev May 30, 2024
8 checks passed
@zhyian zhyian deleted the bugfix/default-campo-keys-value branch May 30, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants