Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-428] Split massive HIS code relationship queries into smaller ones #13

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Jul 2, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix

What is the current behavior? (You can also link to an open issue here)
Jira ticket FAU-428
Discussion in Slack

What is the new behavior (if this is a feature change)?
Split massive HIS code relationship queries into smaller ones.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

@zhyian zhyian changed the title [FAU-428] Split [FAU-428] Split massive HIS code relationship queries into smaller ones Jul 2, 2024
@zhyian zhyian marked this pull request as ready for review July 2, 2024 16:28
@zhyian zhyian requested review from shvlv, amiut and o-samaras July 2, 2024 16:28
Copy link
Collaborator

@o-samaras o-samaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this, but code-wise LGTM. Thank you 💪

Copy link
Collaborator

@amiut amiut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant 👌 Thanks for taking care of it

Copy link
Collaborator

@shvlv shvlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhyian zhyian merged commit fc1f347 into dev Jul 3, 2024
8 checks passed
@zhyian zhyian deleted the FAU-428 branch July 3, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants