Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-446] Support for Multi-Word Free Text Search #21

Merged
merged 2 commits into from
Dec 24, 2024
Merged

[FAU-446] Support for Multi-Word Free Text Search #21

merged 2 commits into from
Dec 24, 2024

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Dec 23, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-446

What is the new behavior (if this is a feature change)?
The search algorithm has been updated to handle multi-word queries. The search results now include degree programs where all searched terms appear in any order within the relevant fields.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

@zhyian zhyian marked this pull request as ready for review December 23, 2024 05:52
@zhyian zhyian requested review from shvlv and o-samaras December 23, 2024 05:53
Copy link
Collaborator

@o-samaras o-samaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM. I 'm afraid this will have a performance hit when longer phrases are used but shouldn't be too obvious or cause issues on the search functionality. Thank you for working on this!

Copy link
Collaborator

@shvlv shvlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Orestis that MySQL is not the best engine for full-text search, but we replicate WordPress's core functionality. Thanks for implementing!

@zhyian zhyian merged commit 97b104c into main Dec 24, 2024
8 checks passed
@zhyian zhyian deleted the FAU-446 branch December 24, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants