Merge pull request #42 from RRZE-Webteam/FAU-434

[FAU-434] Correctly assign campo keys to multiple terms within degree program
RRZE-Webteam · Sep 4, 2024 · 0e4e9c7 · 0e4e9c7
2 parents 6db6806 + fba35b5
commit 0e4e9c7
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Implemented synchronization for campo keys of child terms.
+
 ## [2.0.0] - 2024-07-24
 
 ### Added

diff --git a/composer.lock b/composer.lock
diff --git a/src/Infrastructure/Search/FilterableTermsUpdater.php b/src/Infrastructure/Search/FilterableTermsUpdater.php
@@ -141,19 +141,19 @@ private function setObjectTerms(
         string $taxonomy,
         MultilingualString|MultilingualList|MultilingualLink|MultilingualLinks|Degree|AdmissionRequirement $property
     ): void {
-
-        $termIds = $this->maybeCreateTerms($taxonomy, $property);
+        /** @var array<int, TermData> $terms */
+        $terms = $this->maybeCreateTerms($taxonomy, $property);
         wp_set_object_terms(
             $rawView->id()->asInt(),
-            $termIds,
+            array_keys($terms),
             $taxonomy
         );
 
-        if (! isset($termIds[0])) {
+        if (!$terms) {
             return;
         }
 
-        $this->maybeUpdateCampoKeys($rawView, $taxonomy, (int) $termIds[0]);
+        $this->maybeUpdateCampoKeys($rawView, $taxonomy, $terms);
     }
 
     private function isValidPostId(int $postId): bool
@@ -179,6 +179,8 @@ private function isValidPostId(int $postId): bool
      * phpcs:disable Inpsyde.CodeQuality.FunctionLength.TooLong
      *
      * Refactoring could decrease performance.
+     *
+     * @return array<int, TermData>
      */
     private function maybeCreateTerms(
         string $taxonomy,
@@ -225,15 +227,15 @@ private function maybeCreateTerms(
 
             if ($termData->termId()) {
                 // Term was persisted already
-                $result[] = $termData->termId();
+                $result[$termData->termId()] = $termData;
                 $this->updateTerm($termData);
                 continue;
             }
 
             $termId = $this->createTerm($termData);
 
             if (is_int($termId)) {
-                $result[] = $termId;
+                $result[$termId] = $termData;
                 $taxonomiesCache[$taxonomy][$termId] = [
                     self::TAXONOMIES_CACHE_NAME_PROPERTY => $termData->name()->inGerman(),
                     self::TAXONOMIES_CACHE_ORIGINAL_ID_PROPERTY => $termData->remoteTermId(),
@@ -540,16 +542,25 @@ private static function arraySearchBy(array $array, string $property, mixed $val
         return null;
     }
 
-    private function maybeUpdateCampoKeys(DegreeProgramViewRaw $rawView, string $taxonomy, int $termId): void
+    private function maybeUpdateCampoKeys(DegreeProgramViewRaw $rawView, string $taxonomy, array $terms): void
     {
         $campoKeys = $rawView->campoKeys()->asArray();
         $campoKeyType = CampoKeysRepository::TAXONOMY_TO_CAMPO_KEY_MAP[$taxonomy] ?? '';
-        $campoKey = $campoKeys[$campoKeyType] ?? null;
+        $taxonomyCampoKeys = $campoKeys[$campoKeyType] ?? null;
 
-        if (is_null($campoKey)) {
+        if (!is_array($taxonomyCampoKeys)) {
             return;
         }
 
-        update_term_meta($termId, CampoKeysRepository::CAMPO_KEY_TERM_META_KEY, $campoKey);
+        /** @var TermData $term */
+        foreach ($terms as $term) {
+            $termCampoKey = $taxonomyCampoKeys[$term->remoteTermId()] ?? null;
+
+            if (is_null($termCampoKey)) {
+                continue;
+            }
+
+            update_term_meta($term->termId(), CampoKeysRepository::CAMPO_KEY_TERM_META_KEY, $termCampoKey);
+        }
     }
 }