Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-407] Initial preparation #21

Merged
merged 7 commits into from
Apr 29, 2024
Merged

[FAU-407] Initial preparation #21

merged 7 commits into from
Apr 29, 2024

Conversation

amiut
Copy link
Collaborator

@amiut amiut commented Apr 26, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-407

What is the new behavior (if this is a feature change)?

  • Added PR template
  • Update package name to rrze-webteam/fau-studium

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

@amiut amiut marked this pull request as ready for review April 26, 2024 19:42
@amiut amiut requested review from shvlv, tyrann0us and o-samaras April 26, 2024 19:44
Copy link
Collaborator

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the changes to composer.json, please update composer.lock. The QA checks currently fail because of this.

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@o-samaras o-samaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment but other than that, LGTM. Thanks.

fau-degree-program-output.php Outdated Show resolved Hide resolved
@tyrann0us tyrann0us changed the base branch from main to dev April 29, 2024 08:07
@tyrann0us tyrann0us changed the base branch from dev to main April 29, 2024 08:22
Copy link
Collaborator

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this and incorporating the changes! 🙏🏽

fau-degree-program-output.php Outdated Show resolved Hide resolved
@amiut amiut merged commit fd72571 into main Apr 29, 2024
6 checks passed
@amiut amiut deleted the FAU-407 branch April 29, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants