[FAU-418] Implement live search in the degree programs overview form #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shvlv
approved these changes
May 20, 2024
There was a problem hiding this comment.
As we discussed, the approach is a bit complicated because it uses a REST API JSON response, which requires generating HTML additionally. However, I like it because it's aligned with the general idea of using REST API. It could even be the first step to generating a degree program overview by getting REST API data from the providing website in real-time.
It works locally as expected.
Thanks!
resources/ts/degree-program-overview/degree-program-overview.ts
Outdated
Show resolved
Hide resolved
resources/ts/degree-program-overview/degree-program-overview.ts
Outdated
Show resolved
Hide resolved
resources/ts/degree-program-overview/degree-program-overview.ts
Outdated
Show resolved
Hide resolved
resources/ts/degree-program-overview/degree-program-overview.ts
Outdated
Show resolved
Hide resolved
amiut
reviewed
May 21, 2024
There was a problem hiding this comment.
Thanks a lot for taking care of this, LGTM and works nicely locally.
There are only two things that I noticed:
- When typing something in the search input and then clear the search input, the search doesn't trigger, and previous keyword remains applied. same happens if you remove letter by letter, it works until 3 characters left.
- When triggering search, order and orderby are not preserved and get removed when filters are applied.
|
Thank you for the review!
|
amiut
approved these changes
May 22, 2024
tyrann0us
approved these changes
May 23, 2024
Co-authored-by: Philipp Bammes <[email protected]>
o-samaras
reviewed
May 23, 2024
tyrann0us
reviewed
May 24, 2024
Co-authored-by: Philipp Bammes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-418
What is the new behavior (if this is a feature change)?
Added live search functionality, instead of page reloading we receive data via REST API.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Psalm issue should be fixed after we merge this PR.