Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete files #32

Merged
merged 2 commits into from
May 30, 2024
Merged

Remove obsolete files #32

merged 2 commits into from
May 30, 2024

Conversation

tyrann0us
Copy link
Collaborator

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix

What is the current behavior? (You can also link to an open issue here)
The previous private to public repository GitHub Actions-based synchronization for v1 of the plugins erroneously did not include the deletion of files. See internal discussion: https://inpsyde.slack.com/archives/C045KFJ9MB5/p1716470142721149.

What is the new behavior (if this is a feature change)?
Obsolete files removed

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Should not; functional testing is appreciated.

Other information:
I identified obsolete files by comparing the latest state of the private repository with https://github.com/RRZE-Webteam/FAU-Studium-Embed/tree/943a77250d95eb41e0eff4612e1730f1b4d62459 (the state of the last commit before we started to work in the public repository).
Related PRs:

Copy link
Collaborator

@zhyian zhyian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for handling this. After a quick test, everything works as expected.

@tyrann0us tyrann0us merged commit 7d201d9 into dev May 30, 2024
7 checks passed
@tyrann0us tyrann0us deleted the bugfix/obsolete-files branch May 30, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants