[FAU-376] Apply max-height rule per filter inside the advanced filters #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o-samaras
approved these changes
Jun 12, 2024
shvlv
approved these changes
Jun 13, 2024
tyrann0us
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Style update
What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-376, the "Advanced filters" comments.
Discussion: the height of filters inside the advanced filters is not limited.
What is the new behavior (if this is a feature change)?
Removed the specific
max-heightrule for filters within the advanced filters. Now, the height is limited to 410px.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: