-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FAU-404] Increase API fetch timeout #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of it, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM
Co-authored-by: Orestis Samaras <[email protected]>
Jira: FAU-404Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-404
What is the new behavior (if this is a feature change)?
For unknown reasons, the providing website sometimes takes longer than five seconds to return the degree programs in REST API requests. Due to suboptimal error handling, this leads to the "The degree program data is being processed. Please try again in a few minutes." notice being displayed on the outputting websites.
Increasing the timeout to 15 seconds ensures that the degree programs can be correctly fetched in the daily cache invalidation runs.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
I also updated the
CHANGELOG.md
with all v2 Package 1 changes and included a Markdown table fix according to the Boy Scout rule.