Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-404] Increase API fetch timeout #35

Merged
merged 5 commits into from
Jun 19, 2024
Merged

[FAU-404] Increase API fetch timeout #35

merged 5 commits into from
Jun 19, 2024

Conversation

tyrann0us
Copy link
Collaborator

Jira: FAU-404Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-404

What is the new behavior (if this is a feature change)?
For unknown reasons, the providing website sometimes takes longer than five seconds to return the degree programs in REST API requests. Due to suboptimal error handling, this leads to the "The degree program data is being processed. Please try again in a few minutes." notice being displayed on the outputting websites.
Increasing the timeout to 15 seconds ensures that the degree programs can be correctly fetched in the daily cache invalidation runs.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
I also updated the CHANGELOG.md with all v2 Package 1 changes and included a Markdown table fix according to the Boy Scout rule.

Copy link
Collaborator

@amiut amiut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it, LGTM

Copy link
Collaborator

@zhyian zhyian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

Copy link
Collaborator

@o-samaras o-samaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Orestis Samaras <[email protected]>
@tyrann0us tyrann0us merged commit 63e1ec0 into dev Jun 19, 2024
7 checks passed
@tyrann0us tyrann0us deleted the FAU-404 branch June 19, 2024 09:14
@tyrann0us tyrann0us changed the title [FAU-404] Increase API fetch timeou [FAU-404] Increase API fetch timeout Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants