Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-445] Restrict search to pre-selected degree programs #46

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Dec 19, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-445

What is the new behavior (if this is a feature change)?
Pre-selected filters are now added as hidden inputs, ensuring that all they are included in form submissions without any additional handling.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
Additionally, I updated several internal packages: inpsyde/assets, inpsyde/modularity, inpsyde/wp-context. These updates fix text domain loading issues and resolve other problems.

@zhyian zhyian marked this pull request as ready for review December 19, 2024 10:35
@zhyian zhyian requested review from shvlv, amiut and o-samaras December 19, 2024 10:35
Copy link
Collaborator

@o-samaras o-samaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. Code-wise LGTM

Copy link
Collaborator

@amiut amiut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it, LGTM

Copy link
Collaborator

@shvlv shvlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zhyian zhyian merged commit c60a3c0 into dev Dec 24, 2024
6 checks passed
@zhyian zhyian deleted the FAU-445 branch December 24, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants