Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-448] Allow users to specify search fields #50

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Dec 24, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-448

What is the new behavior (if this is a feature change)?
Added a checkbox, 'Also search in text'/'Auch im Text suchen', to extend the search to the 'What is the degree program about?'/'Worum geht es im Studiengang?' field when selected. This introduces an additional fau_degree_program_searchable_content_extended post meta to store values for the extended search.

Since the design was not specified, I placed it under the search input:

image image

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

@zhyian zhyian marked this pull request as ready for review December 26, 2024 13:52
@zhyian zhyian requested review from shvlv and o-samaras December 26, 2024 13:52
Copy link
Collaborator

@shvlv shvlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants