Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-449] Trigger search only when checkbox state changes #51

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Conversation

zhyian
Copy link
Collaborator

@zhyian zhyian commented Dec 26, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-449

What is the new behavior (if this is a feature change)?
This PR improves the behavior of filter dropdowns to ensure that searches are triggered only under specific conditions:

  • When Reduced Motion is disabled, closing any filter dropdown does not trigger a search.
  • When Reduced Motion is enabled, the system triggers a search only if one or more filter parameters inside the dropdown are changed before closing.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

@zhyian zhyian marked this pull request as ready for review December 26, 2024 16:12
@zhyian zhyian requested review from shvlv and o-samaras December 26, 2024 16:13
resources/ts/filters/filter-dropdown.ts Outdated Show resolved Hide resolved
resources/ts/filters/filter-dropdown.ts Outdated Show resolved Hide resolved
@zhyian zhyian requested a review from amiut January 2, 2025 09:55
Copy link
Collaborator

@amiut amiut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thank you, LGTM

@zhyian zhyian merged commit 06a0f2a into dev Jan 3, 2025
1 check passed
@zhyian zhyian deleted the FAU-449 branch January 3, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants