Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-423] Use <TextControl> for duration of studies #127

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

tyrann0us
Copy link
Collaborator

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-423
"Duration of studies in semester" field is a multi-line input (<TextareaControlFormField>).

What is the new behavior (if this is a feature change)?
"Duration of studies in semester" field is a single-line input (<TextControl>).

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, existing content will be kept.

Before:
Bildschirmfoto 2024-05-03 um 11 46 20

After:
Bildschirmfoto 2024-05-03 um 11 48 00

Other information:
There's currently an unrelated error preventing any input (source). However, this shouldn't affect this change (or vice versa).

@tyrann0us tyrann0us requested review from shvlv, zhyian, amiut and o-samaras May 3, 2024 09:49
Copy link
Collaborator

@amiut amiut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it, LGTM, left a small (unrelated) suggestion but nothing that prevents me from approving.

Copy link
Collaborator

@zhyian zhyian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tyrann0us tyrann0us merged commit b936811 into dev May 7, 2024
1 check passed
@tyrann0us tyrann0us deleted the FAU-423 branch May 7, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants