Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-422] Support core "Quote" block #128

Merged
merged 5 commits into from
May 7, 2024
Merged

[FAU-422] Support core "Quote" block #128

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e0aa98
fix: remove `onChange` dependency of `useEffect`
tyrann0us May 3, 2024
51ce5d4
feat: allow quote block
tyrann0us May 6, 2024
dcb651f
chore: update changelog
tyrann0us May 6, 2024
8e7de49
chore: update rrze/fau-studium-common
tyrann0us May 7, 2024
99ad3c6
Merge branch 'dev' into FAU-422
tyrann0us May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Support WordPress "Quote" block in content fields.

## [1.2.7] - 2023-11-23

### Fixed
Expand Down
1 change: 1 addition & 0 deletions resources/ts/components/ContentField/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export const ALLOWED_BLOCK_TYPES = [
'core/list-item',
'core/heading',
'core/shortcode',
'core/quote',
'fau/description-list',
'fau/description-term',
'fau/description-details',
Expand Down
2 changes: 1 addition & 1 deletion resources/ts/components/TextControlCollection/TextControlCollection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
onChange(
fields.filter( ( f ) => !! f.value ).map( ( f ) => f.value )
);
}, [ fields, onChange ] );
}, [ fields ] );

Check warning on line 76 in resources/ts/components/TextControlCollection/TextControlCollection.tsx

View workflow job for this annotation

GitHub Actions / wp-scripts-lint / static-analysis-assets 

React Hook useEffect has a missing dependency: 'onChange'. Either include it or remove the dependency array. If 'onChange' changes too often, find the parent component that defines it and wrap that definition in useCallback

const { required } = useFieldContext();

Expand Down