Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAU-414] Add support for campo keys #132

Merged
merged 9 commits into from
May 24, 2024
Merged

[FAU-414] Add support for campo keys #132

merged 9 commits into from
May 24, 2024

Conversation

amiut
Copy link
Collaborator

@amiut amiut commented May 15, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
https://inpsyde.atlassian.net/browse/FAU-414

What is the new behavior (if this is a feature change)?
Add support for campo keys.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Related PRs:

Other information:
This PR needs to be revisited once #131 is merged

@amiut amiut changed the title Fau 414 [FAU-414] Add support for campo keys May 21, 2024
@amiut amiut marked this pull request as ready for review May 21, 2024 15:05
@amiut amiut requested review from shvlv, tyrann0us, zhyian and o-samaras May 21, 2024 15:05
Copy link
Collaborator

@zhyian zhyian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, LGTM and works good. 💪🏼

Copy link
Collaborator

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a minor comment that doesn't stop me from approving.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Philipp Bammes <[email protected]>
Base automatically changed from FAU-411-alternative to dev May 24, 2024 14:13
@amiut amiut merged commit 3ef6b07 into dev May 24, 2024
8 checks passed
@amiut amiut deleted the FAU-414 branch May 24, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants