Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commands): use functions for dynamic translations #2558

Closed
wants to merge 1 commit into from

Conversation

kovsu
Copy link
Contributor

@kovsu kovsu commented Jan 13, 2025

Description

My language setting is zh, but it renders en at first time.

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Linked Issues

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

@follow-reviewer-bot
Copy link

Thank you for your contribution. We will review it promptly.

@follow-reviewer-bot
Copy link

Suggested PR Title:

refactor: use functions for command label translations

Change Summary:
Refactor command labels to use functions for translation

Code Review:
No change requests necessary.

Copy link

vercel bot commented Jan 13, 2025

@kovsu is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

@kovsu
Copy link
Contributor Author

kovsu commented Jan 13, 2025

But it seems work fine in https://app.follow.is, the problem only appear in my development enviroment. Feel free to close this pr.

Copy link
Member

@Innei Innei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should put the t in the hooks options deps. instead of change this

Copy link
Member

@Innei Innei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2025-01-13 at 5  08 44@2x

@kovsu
Copy link
Contributor Author

kovsu commented Jan 13, 2025

@Innei I tried it. But it doesn't work for me. I will check it again.

@kovsu
Copy link
Contributor Author

kovsu commented Jan 14, 2025

You should put the t in the hooks options deps. instead of change this

@Innei 大佬,maybe you can check this and update this pr. I failed 🤡

@hyoban
Copy link
Member

hyoban commented Jan 16, 2025

@lawvs cc

@lawvs
Copy link
Member

lawvs commented Jan 16, 2025

Thank you very much for your feedback, but the root cause of this issue is not here. I will fix the problem at #2590. Still, I appreciate your contribution to the project.

@lawvs lawvs closed this Jan 16, 2025
@kovsu kovsu deleted the fix-1 branch January 17, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants